Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issue 13137002: Adapt remaining dart:scalarlist tests to use dart:typeddata (Closed)

Created:
7 years, 9 months ago by siva
Modified:
7 years, 9 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adapt remaining dart:scalarlist tests to use dart:typeddata Committed: https://code.google.com/p/dart/source/detail?r=20643

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+571 lines, -485 lines) Patch
M runtime/lib/typeddata.dart View 1 64 chunks +231 lines, -147 lines 0 comments Download
M runtime/tests/vm/dart/byte_array_optimized_test.dart View 1 21 chunks +165 lines, -165 lines 0 comments Download
M runtime/tests/vm/dart/byte_array_test.dart View 1 24 chunks +175 lines, -173 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
siva
7 years, 9 months ago (2013-03-28 03:35:59 UTC) #1
srdjan
lgtm
7 years, 9 months ago (2013-03-28 18:40:17 UTC) #2
siva
- Added a _throwRangeError method which I call instead when a range error occurs as ...
7 years, 9 months ago (2013-03-28 20:44:06 UTC) #3
siva
7 years, 9 months ago (2013-03-28 20:52:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20643 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698