Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 1313393003: Do not request a client certificate as the default for SSL. (Closed)

Created:
5 years, 3 months ago by Bill Hesse
Modified:
5 years, 3 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Do not request a client certificate as the default for SSL. BUG= TBR=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/891c36a8e03399dcb4ef53e20b2fa0ef5260b51a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M runtime/bin/secure_socket.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Bill Hesse
5 years, 3 months ago (2015-08-26 16:47:25 UTC) #2
Bill Hesse
Committed patchset #1 (id:1) manually as 891c36a8e03399dcb4ef53e20b2fa0ef5260b51a (presubmit successful).
5 years, 3 months ago (2015-08-26 16:48:29 UTC) #3
kustermann
5 years, 3 months ago (2015-08-26 18:38:24 UTC) #4
Message was sent while issue was closed.
LGTM

Do you know why our tests just worked (they don't provide a client certificate,
do they?

Powered by Google App Engine
This is Rietveld 408576698