Add visitor methods specific to ??= to SemanticSendVisitor.

Add visitor methods specific to ??= to SemanticSendVisitor.

BUG=
R=karlklose@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/876bad5b80a1626626dc007025da813e3d93caae

[Johnni Winther, 2015-08-26 10:34:55]

johnniwinther@google.com changed reviewers:
+ karlklose@google.com

[Johnni Winther, 2015-08-26 10:34:55]

Main changes in semantic_visitor.dart

[karlklose, 2015-08-26 12:39:22]

LGTM.

https://codereview.chromium.org/1313323002/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right):

https://codereview.chromium.org/1313323002/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:1356: {ir.Primitive
getValue(),
getValue is called unconditionally, so it is not really optional, is it?  Is it
an optional named parameter just to have a name in the argument list?

https://codereview.chromium.org/1313323002/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/semantic_visitor.dart (right):

https://codereview.chromium.org/1313323002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:2193: /// [receiver]. That
is, evaluation and assignment of [rhs] only if the value
'That is, [rhs] is only evaluated and assigned, if the value of receiver.name is
`null`.'

https://codereview.chromium.org/1313323002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:2743: /// getter is
`null`. This is in other words a no such method error.
Maybe split the last sentence into its own paragraph in all these cases and
rephrase to say that the behavior is equivalent to ....

https://codereview.chromium.org/1313323002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:2849: ///     m(rhs) => F
+= rhs;
'+=' -> '??=' (also the two cases below)

[Siggi Cherem (dart-lang), 2015-08-26 21:25:01]

sigmund@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2015-08-26 21:25:01]

lgtm

https://codereview.chromium.org/1313323002/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/send_structure.dart (right):

https://codereview.chromium.org/1313323002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/send_structure.dart:1630: /// The structure for
a [Send] that is a compound assignment. For instance
same comment Karl had in the other file (s/compound/if-null/, s/+=/??=/)

[Johnni Winther, 2015-08-28 08:12:13]

https://codereview.chromium.org/1313323002/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right):

https://codereview.chromium.org/1313323002/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:1356: {ir.Primitive
getValue(),
On 2015/08/26 12:39:22, karlklose wrote:
> getValue is called unconditionally, so it is not really optional, is it?  Is
it
> an optional named parameter just to have a name in the argument list?

Yes. Pending the introduction of required named arguments which we should have
had to begin with....

https://codereview.chromium.org/1313323002/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/semantic_visitor.dart (right):

https://codereview.chromium.org/1313323002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:2193: /// [receiver]. That
is, evaluation and assignment of [rhs] only if the value
On 2015/08/26 12:39:22, karlklose wrote:
> 'That is, [rhs] is only evaluated and assigned, if the value of receiver.name
is
> `null`.'

Done.

https://codereview.chromium.org/1313323002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:2743: /// getter is
`null`. This is in other words a no such method error.
On 2015/08/26 12:39:22, karlklose wrote:
> Maybe split the last sentence into its own paragraph in all these cases and
> rephrase to say that the behavior is equivalent to ....

Rephrased.

https://codereview.chromium.org/1313323002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:2849: ///     m(rhs) => F
+= rhs;
On 2015/08/26 12:39:22, karlklose wrote:
> '+=' -> '??=' (also the two cases below)

Done.

https://codereview.chromium.org/1313323002/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/send_structure.dart (right):

https://codereview.chromium.org/1313323002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/send_structure.dart:1630: /// The structure for
a [Send] that is a compound assignment. For instance
On 2015/08/26 21:25:01, Siggi Cherem (dart-lang) wrote:
> same comment Karl had in the other file (s/compound/if-null/, s/+=/??=/)

Done.

[Johnni Winther, 2015-08-28 08:17:33]

Committed patchset #2 (id:20001) manually as
876bad5b80a1626626dc007025da813e3d93caae (presubmit successful).