Issue 1313183007: dart2js cps: Interceptor can be null if input is null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1313183007: dart2js cps: Interceptor can be null if input is null. (Closed)

Created:
5 years, 3 months ago by asgerf

Modified:
5 years, 3 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js cps: Interceptor can be null if input is null. This causes nasty regression but it fixes a correctness issue. Path-sensitive type propagation recovers some of the regression. R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/9ac5099a46a3b7df8a2a77b13450d037bf1126a8

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	pkg/compiler/lib/src/cps_ir/type_propagation.dart	View	1	1 chunk	+10 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

asgerf

5 years, 3 months ago (2015-08-28 15:16:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
9ac5099a46a3b7df8a2a77b13450d037bf1126a8 (presubmit successful).