Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1313073007: Move parser and token related libraries into their own subfolder. (Closed)

Created:
5 years, 3 months ago by Johnni Winther
Modified:
5 years, 3 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move parser and token related libraries into their own subfolder. BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/ee54b9e3cd938a8f0c2674edf7be5381927f8aa0

Patch Set 1 #

Patch Set 2 : Fix unittests and try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -7108 lines) Patch
M pkg/compiler/lib/src/closure.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 3 chunks +13 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/dart_backend/dart_backend.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/source_span.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/io/start_end_information.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/mirror_renamer/mirror_renamer.dart View 1 chunk +8 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/native/native.dart View 1 chunk +5 lines, -5 lines 0 comments Download
A + pkg/compiler/lib/src/parser/class_element_parser.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A + pkg/compiler/lib/src/parser/diet_parser_task.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/compiler/lib/src/parser/listener.dart View 2 chunks +10 lines, -10 lines 0 comments Download
A + pkg/compiler/lib/src/parser/parser.dart View 2 chunks +9 lines, -9 lines 0 comments Download
A + pkg/compiler/lib/src/parser/parser_task.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A + pkg/compiler/lib/src/parser/partial_parser.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/scanner/array_based_scanner.dart View 2 chunks +10 lines, -10 lines 0 comments Download
D pkg/compiler/lib/src/scanner/class_element_parser.dart View 1 chunk +0 lines, -286 lines 0 comments Download
D pkg/compiler/lib/src/scanner/diet_parser_task.dart View 1 chunk +0 lines, -41 lines 0 comments Download
D pkg/compiler/lib/src/scanner/keyword.dart View 1 chunk +0 lines, -219 lines 0 comments Download
D pkg/compiler/lib/src/scanner/listener.dart View 1 chunk +0 lines, -2673 lines 0 comments Download
D pkg/compiler/lib/src/scanner/parser.dart View 1 chunk +0 lines, -2721 lines 0 comments Download
D pkg/compiler/lib/src/scanner/parser_task.dart View 1 chunk +0 lines, -49 lines 0 comments Download
D pkg/compiler/lib/src/scanner/partial_parser.dart View 1 chunk +0 lines, -181 lines 0 comments Download
M pkg/compiler/lib/src/scanner/scanner.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/scanner/scanner_task.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/scanner/string_scanner.dart View 1 chunk +4 lines, -4 lines 0 comments Download
D pkg/compiler/lib/src/scanner/token.dart View 1 chunk +0 lines, -756 lines 0 comments Download
D pkg/compiler/lib/src/scanner/token_map.dart View 1 chunk +0 lines, -47 lines 0 comments Download
M pkg/compiler/lib/src/scanner/utf8_bytes_scanner.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/string_validator.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/compiler/lib/src/tokens/keyword.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/compiler/lib/src/tokens/token.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/compiler/lib/src/tokens/token_map.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M pkg/compiler/lib/src/tree/tree.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/dart2js_incremental/lib/diff.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/dart2js_incremental/lib/library_updater.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M site/try/poi/poi.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M site/try/src/editor.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M site/try/src/interaction_manager.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/backend_dart/dart_printer_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/metadata_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/parser_helper.dart View 1 2 chunks +8 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/scanner_offset_length_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/scanner_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/unparser2_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/try/poi/apply_updates_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/try/poi/forget_element_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Johnni Winther
Main changes in scanner/* parser/* and tokens/* folders
5 years, 3 months ago (2015-09-02 08:18:05 UTC) #2
karlklose
LGTM.
5 years, 3 months ago (2015-09-02 08:52:28 UTC) #3
Johnni Winther
PTAL
5 years, 3 months ago (2015-09-02 08:58:21 UTC) #4
karlklose
LGTM.
5 years, 3 months ago (2015-09-02 10:03:43 UTC) #5
Johnni Winther
5 years, 3 months ago (2015-09-02 10:07:10 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
ee54b9e3cd938a8f0c2674edf7be5381927f8aa0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698