Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issue 1312903010: Split double_parse_test into more multitests. (Closed)

Created:
5 years, 3 months ago by Mads Ager (google)
Modified:
5 years, 3 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Split double_parse_test into more multitests. The 03 multitest cases are the ones that fail on arm using the system strtod. Separating them out makes it easier to do suppresions of only the parts of the tests that fail in a given configuration. R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/7ae093a3b8895bde88401df2cb6a7b672adefca6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -212 lines) Patch
M tests/corelib/double_parse_test.dart View 11 chunks +212 lines, -212 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (google)
5 years, 3 months ago (2015-09-01 14:20:14 UTC) #1
floitsch
LGTM.
5 years, 3 months ago (2015-09-01 14:25:37 UTC) #2
Mads Ager (google)
5 years, 3 months ago (2015-09-01 14:27:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7ae093a3b8895bde88401df2cb6a7b672adefca6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698