Issue 1312893007: Split two string to double corner cases into a separate multitest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1312893007: Split two string to double corner cases into a separate multitest. (Closed)

Created:
5 years, 3 months ago by Mads Ager (google)

Modified:
5 years, 3 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Split two string to double corner cases into a separate multitest. When using a simpler version of the doubleconversion library that uses the system strtod to parse strings these cases fail on MacOS. Splitting them out allows us to mark only these corner cases as failing on MacOS. R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/bb8ca393e15c8eb8b773cf597219a936f6bfae47

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -36 lines)			Patch
	M	tests/corelib/double_parse_test.dart	View		2 chunks	+36 lines, -36 lines	0 comments	Download

Total messages: 3 (0 generated)

Mads Ager (google)

5 years, 3 months ago (2015-09-01 08:20:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bb8ca393e15c8eb8b773cf597219a936f6bfae47 (presubmit successful).