Issue 1312793004: Fix NotifyPauseOnStart and NotifyPauseOnExit dead lock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1312793004: Fix NotifyPauseOnStart and NotifyPauseOnExit dead lock (Closed)

Created:
5 years, 4 months ago by Cutch

Modified:
5 years, 4 months ago

Reviewers:
turnidge, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix NotifyPauseOnStart and NotifyPauseOnExit dead lock BUG= R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/2bde86513831b2e8d6a2bad62c726ea17dae3faf

Patch Set 2 : #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	runtime/vm/message_handler.cc	View	1	4 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

turnidge

lgtm w/ 1 comment https://codereview.chromium.org/1312793004/diff/1/runtime/vm/message_handler.cc File runtime/vm/message_handler.cc (right): https://codereview.chromium.org/1312793004/diff/1/runtime/vm/message_handler.cc#newcode290 runtime/vm/message_handler.cc:290: NotifyPauseOnExit(); Handle this like run_end_callback ...

5 years, 4 months ago (2015-08-24 17:39:55 UTC) #4

Cutch

5 years, 4 months ago (2015-08-24 17:47:44 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
2bde86513831b2e8d6a2bad62c726ea17dae3faf (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1312793004: Fix NotifyPauseOnStart and NotifyPauseOnExit dead lock (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages