Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 13125002: Fix checked mode crash when clearing reaching type of a value. (Closed)

Created:
7 years, 9 months ago by srdjan
Modified:
7 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix checked mode crash when clearing reaching type of a value. When replacing uses we clear type information that is set by a previous type propagation (e.g. by CheckSmi). This led to unexpected behavior: value guarded by a CheckSmi but not Smi. Adding another type propagation pass before code generation. Committed: https://code.google.com/p/dart/source/detail?r=20921

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M runtime/vm/flow_graph_optimizer.cc View 1 2 3 4 2 chunks +10 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
srdjan
7 years, 9 months ago (2013-03-27 23:10:03 UTC) #1
srdjan
Please hold off with the review, it fixed one issue but not all. Working ....
7 years, 9 months ago (2013-03-27 23:34:10 UTC) #2
Vyacheslav Egorov (Google)
I find it confusing: I thought we clear only those types that are equal to ...
7 years, 9 months ago (2013-03-27 23:36:54 UTC) #3
srdjan
PTAL. There is a discrepancy between what type is stored in the value and its ...
7 years, 8 months ago (2013-03-29 20:38:59 UTC) #4
Vyacheslav Egorov (Google)
lgtm
7 years, 8 months ago (2013-04-02 11:02:37 UTC) #5
srdjan
7 years, 8 months ago (2013-04-04 16:13:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #5 manually as r20921 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698