Issue 1312363005: Add Element.endSourceSpan

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1312363005: Add Element.endSourceSpan (Closed)

Created:
5 years, 3 months ago by scheglov

Modified:
5 years, 3 months ago

Reviewers:
Siggi Cherem (dart-lang), Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/html@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add Element.endSourceSpan R=jmesserly@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/html/commit/71774938f96ab1fe27ed980cab87330c4eacc5b7

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+199 lines, -20 lines)			Patch
M	lib/dom.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	lib/parser.dart	View	23 chunks	+50 lines, -19 lines	0 comments	Download
M	lib/src/treebuilder.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/parser_feature_test.dart	View	2 chunks	+142 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

lgtm. Thank you! I can push out a release of this too, if that helps.

5 years, 3 months ago (2015-08-26 16:35:50 UTC) #2

scheglov

Committed patchset #1 (id:1) manually as 71774938f96ab1fe27ed980cab87330c4eacc5b7 (presubmit successful).

5 years, 3 months ago (2015-08-26 16:47:35 UTC) #3

scheglov

5 years, 3 months ago (2015-08-26 16:49:12 UTC) #4

Message was sent while issue was closed.

On 2015/08/26 16:35:50, John Messerly wrote:
> lgtm. Thank you! I can push out a release of this too, if that helps.

Yes, I'd like to start using it in the Angular plugin, so it would be nice to
have it published.

Expand Messages | Collapse Messages