Issue 131233011: Set the correct mime types for assets served via pub serve.

Issue 131233011: Set the correct mime types for assets served via pub serve. (Closed)

Created:
6 years, 10 months ago by nweiz

Modified:
6 years, 10 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Set the correct mime types for assets served via pub serve. R=rnystrom@google.com BUG=14815 Committed: https://code.google.com/p/dart/source/detail?r=32580

Patch Set 2 : code review #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -2 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/barback/server.dart	View		2 chunks	+2 lines, -0 lines	0 comments	Download
A	sdk/lib/_internal/pub/test/serve/uses_appropriate_mime_types_test.dart	View		1 chunk	+37 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/utils.dart	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

One nit then LGTM! https://codereview.chromium.org/131233011/diff/1/sdk/lib/_internal/pub/lib/src/barback/server.dart File sdk/lib/_internal/pub/lib/src/barback/server.dart (right): https://codereview.chromium.org/131233011/diff/1/sdk/lib/_internal/pub/lib/src/barback/server.dart#newcode118 sdk/lib/_internal/pub/lib/src/barback/server.dart:118: request.response.headers.add('content-type', lookupMimeType(id.path)); Hurray for code ...

6 years, 10 months ago (2014-02-11 19:11:13 UTC) #2

nweiz

https://codereview.chromium.org/131233011/diff/1/sdk/lib/_internal/pub/test/serve/utils.dart File sdk/lib/_internal/pub/test/serve/utils.dart (right): https://codereview.chromium.org/131233011/diff/1/sdk/lib/_internal/pub/test/serve/utils.dart#newcode171 sdk/lib/_internal/pub/test/serve/utils.dart:171: /// [expectation] may either be a [Matcher] or a ...

6 years, 10 months ago (2014-02-11 21:45:48 UTC) #3

nweiz

6 years, 10 months ago (2014-02-11 21:45:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r32580 (presubmit successful).

Expand Messages | Collapse Messages