Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 131233009: New analyzer snapshot. (Closed)

Created:
6 years, 10 months ago by scheglov
Modified:
6 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2518 lines, -1239 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/html/ast/RawXmlExpression.java View 2 chunks +1 line, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/html/ast/XmlExpression.java View 2 chunks +5 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisContextImpl.java View 15 chunks +19 lines, -19 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/WorkManager.java View 3 chunks +2 lines, -36 lines 0 comments Download
A editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/WorkManagerPriority.java View 1 chunk +49 lines, -0 lines 1 comment Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/html/angular/AngularXmlExpression.java View 2 chunks +1 line, -4 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/resources/java_io.dart View 2 chunks +5 lines, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/EngineSemanticProcessor.java View 2 chunks +7 lines, -4 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java View 3 chunks +2 lines, -11 lines 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 10 chunks +72 lines, -28 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 149 chunks +1527 lines, -430 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 8 chunks +22 lines, -19 lines 0 comments Download
M pkg/analyzer/lib/src/generated/html.dart View 13 chunks +92 lines, -173 lines 0 comments Download
M pkg/analyzer/lib/src/generated/index.dart View 11 chunks +58 lines, -33 lines 0 comments Download
M pkg/analyzer/lib/src/generated/java_io.dart View 2 chunks +5 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 136 chunks +254 lines, -254 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 55 chunks +193 lines, -183 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 1 chunk +2 lines, -10 lines 1 comment Download
M pkg/analyzer/lib/src/generated/source_io.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/string_source.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 11 chunks +182 lines, -14 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/utils/utils.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 10 months ago (2014-02-06 07:53:21 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/131233009/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/WorkManagerPriority.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/WorkManagerPriority.java (right): https://codereview.chromium.org/131233009/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/WorkManagerPriority.java#newcode21 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/WorkManagerPriority.java:21: public enum WorkManagerPriority { I don't really like ...
6 years, 10 months ago (2014-02-06 14:59:15 UTC) #2
scheglov
6 years, 10 months ago (2014-02-06 15:31:35 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r32362 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698