Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1311963002: Add argument to Dart_Initialize for precompiled instructions. (Closed)

Created:
5 years, 4 months ago by rmacnak
Modified:
5 years, 3 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Cutch
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add argument to Dart_Initialize for precompiled instructions. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/c3abcd8f93d0ec532338259ec95a85c6fa49d03c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M runtime/bin/gen_snapshot.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/run_vm_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/include/dart_api.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/dart.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/dart.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
rmacnak
5 years, 4 months ago (2015-08-24 23:22:03 UTC) #2
rmacnak
5 years, 4 months ago (2015-08-24 23:22:48 UTC) #3
siva
lgtm
5 years, 3 months ago (2015-08-26 17:29:33 UTC) #4
rmacnak
Committed patchset #1 (id:1) manually as c3abcd8f93d0ec532338259ec95a85c6fa49d03c (presubmit successful).
5 years, 3 months ago (2015-08-26 18:04:32 UTC) #5
rmacnak
5 years, 3 months ago (2015-08-26 23:25:46 UTC) #6
Message was sent while issue was closed.
+John, Heads up sky/mojo should just pass another NULL

Powered by Google App Engine
This is Rietveld 408576698