Issue 13119022: Fix an F-bounded quantification bug (issue 9291).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13119022: Fix an F-bounded quantification bug (issue 9291). (Closed)

Created:
7 years, 9 months ago by regis

Modified:
7 years, 9 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix an F-bounded quantification bug (issue 9291). Add regression test. Committed: https://code.google.com/p/dart/source/detail?r=20576

Patch Set 2 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -18 lines)			Patch
M	runtime/vm/class_finalizer.cc	View		3 chunks	+23 lines, -13 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	5 chunks	+16 lines, -5 lines	0 comments	Download
A	tests/language/f_bounded_quantification2_test.dart	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://codereview.chromium.org/13119022/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/13119022/diff/1/runtime/vm/object.cc#newcode9250 runtime/vm/object.cc:9250: // non static and generic, see Class::NumTypeArguments()). Therefore, ...

7 years, 9 months ago (2013-03-27 20:38:13 UTC) #2

regis

Thanks! https://codereview.chromium.org/13119022/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/13119022/diff/1/runtime/vm/object.cc#newcode9250 runtime/vm/object.cc:9250: // non static and generic, see Class::NumTypeArguments()). Therefore, ...

7 years, 9 months ago (2013-03-27 20:41:41 UTC) #3

regis

7 years, 9 months ago (2013-03-27 20:42:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20576 (presubmit successful).

Expand Messages | Collapse Messages

Issue 13119022: Fix an F-bounded quantification bug (issue 9291). (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages