Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 1311783012: Split parser/listener.dart, parser/class_element_listener.dart and tokens/token.dart into smaller l… (Closed)

Created:
5 years, 3 months ago by Johnni Winther
Modified:
5 years, 3 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Split parser/listener.dart, parser/class_element_listener.dart and tokens/token.dart into smaller libraries BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/d6db26f91251f2d277a5fc67df1a3729c945499e

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+892 lines, -11282 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 2 chunks +6 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/native/native.dart View 1 chunk +7 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/native/scanner.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/parser/class_element_parser.dart View 2 chunks +1 line, -268 lines 1 comment Download
M pkg/compiler/lib/src/parser/diet_parser_task.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 1 chunk +535 lines, -2453 lines 0 comments Download
M pkg/compiler/lib/src/parser/listener.dart View 4 chunks +6 lines, -1886 lines 0 comments Download
M pkg/compiler/lib/src/parser/member_listener.dart View 1 chunk +6 lines, -117 lines 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 3 chunks +19 lines, -1876 lines 0 comments Download
M pkg/compiler/lib/src/parser/parser.dart View 2 chunks +27 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/parser/parser_task.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/parser/partial_elements.dart View 5 chunks +108 lines, -2282 lines 1 comment Download
M pkg/compiler/lib/src/parser/partial_parser.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 6 chunks +17 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/scanner/array_based_scanner.dart View 10 chunks +21 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/scanner/scanner.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/scanner/string_scanner.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/scanner/utf8_bytes_scanner.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 3 chunks +7 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/tokens/keyword.dart View 7 chunks +17 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/tokens/precedence.dart View 2 chunks +2 lines, -738 lines 0 comments Download
M pkg/compiler/lib/src/tokens/precedence_constants.dart View 1 chunk +5 lines, -520 lines 0 comments Download
M pkg/compiler/lib/src/tokens/token.dart View 5 chunks +9 lines, -323 lines 0 comments Download
M pkg/compiler/lib/src/tokens/token_constants.dart View 2 chunks +2 lines, -676 lines 0 comments Download
M pkg/compiler/lib/src/tree/nodes.dart View 3 chunks +7 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/tree/tree.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/tree/unparser.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/dart2js_incremental/lib/diff.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M pkg/dart2js_incremental/lib/library_updater.dart View 2 chunks +10 lines, -6 lines 0 comments Download
M site/try/poi/poi.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M site/try/src/editor.dart View 1 chunk +3 lines, -1 line 0 comments Download
M site/try/src/interaction_manager.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/dart_printer_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/metadata_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/parser_helper.dart View 2 chunks +6 lines, -1 line 0 comments Download
M tests/compiler/dart2js/scanner_offset_length_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/scanner_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/unparser2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/try/poi/apply_updates_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/try/poi/forget_element_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
Main changes in parser/*.dart and tokens/*.dart https://codereview.chromium.org/1311783012/diff/1/pkg/compiler/lib/src/parser/class_element_parser.dart File pkg/compiler/lib/src/parser/class_element_parser.dart (left): https://codereview.chromium.org/1311783012/diff/1/pkg/compiler/lib/src/parser/class_element_parser.dart#oldcode55 pkg/compiler/lib/src/parser/class_element_parser.dart:55: class PartialClassElement extends ...
5 years, 3 months ago (2015-09-02 13:14:42 UTC) #2
karlklose
LGTM.
5 years, 3 months ago (2015-09-02 13:26:46 UTC) #3
Johnni Winther
5 years, 3 months ago (2015-09-02 13:55:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d6db26f91251f2d277a5fc67df1a3729c945499e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698