Issue 131173002: Fix http_requested_uri_test for Win/Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 131173002: Fix http_requested_uri_test for Win/Mac. (Closed)

Created:
6 years, 11 months ago by Anders Johnsen

Modified:
6 years, 11 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix http_requested_uri_test for Win/Mac. BUG= Committed: https://code.google.com/p/dart/source/detail?r=31647

Patch Set 1 #

Total comments: 2

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	tests/standalone/io/http_requested_uri_test.dart	View		2 chunks	+2 lines, -2 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

Committed patchset #1 manually as r31647 (presubmit successful).

6 years, 11 months ago (2014-01-09 08:44:00 UTC) #2

Søren Gjesse

https://codereview.chromium.org/131173002/diff/1/tests/standalone/io/http_requested_uri_test.dart File tests/standalone/io/http_requested_uri_test.dart (right): https://codereview.chromium.org/131173002/diff/1/tests/standalone/io/http_requested_uri_test.dart#newcode14 tests/standalone/io/http_requested_uri_test.dart:14: HttpServer.bind("localhost", 0).then((server) { Wheren't the use of localhost the ...

6 years, 11 months ago (2014-01-09 08:53:57 UTC) #3

Søren Gjesse

6 years, 11 months ago (2014-01-09 09:00:56 UTC) #4

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/131173002/diff/1/tests/standalone/io/http_req...
File tests/standalone/io/http_requested_uri_test.dart (right):

https://codereview.chromium.org/131173002/diff/1/tests/standalone/io/http_req...
tests/standalone/io/http_requested_uri_test.dart:14:
HttpServer.bind("localhost", 0).then((server) {
On 2014/01/09 08:53:57, Søren Gjesse wrote:
> Wheren't the use of localhost the source of sporadic errors on our Mac
builders
> (once in a while the lookup would return the IPv4 address instead of the IPv6
> one)?

Thinking about this again the issue was only there if two processes where used.

Expand Messages | Collapse Messages