Issue 1311693003: oneee# Enter a description of the change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1311693003: oneee# Enter a description of the change. (Closed)

Created:
5 years, 3 months ago by srdjan

Modified:
5 years, 3 months ago

Reviewers:
koda

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

oneee# Enter a description of the change. Collect interfaces without GrowableObjectArray Concat to symbol without temporary String creation BUG= R=koda@google.com Committed: https://github.com/dart-lang/sdk/commit/d732b68b8cc620ccefe2a49a90fd14fe059e971c

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -57 lines)			Patch
M	runtime/vm/class_finalizer.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/class_finalizer.cc	View	15 chunks	+49 lines, -49 lines	0 comments	Download
M	runtime/vm/hash_table.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/parser.cc	View	1 chunk	+5 lines, -5 lines	0 comments	Download

Total messages: 5 (1 generated)

koda

lgtm Once all new-space allocation is gone, will you add/update a test to make sure ...

5 years, 3 months ago (2015-08-27 22:00:29 UTC) #3

srdjan

On 2015/08/27 22:00:29, koda wrote: > lgtm > > Once all new-space allocation is gone, ...

5 years, 3 months ago (2015-08-28 15:22:33 UTC) #4

srdjan

5 years, 3 months ago (2015-08-28 15:25:52 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d732b68b8cc620ccefe2a49a90fd14fe059e971c (presubmit successful).