Issue 1311673009: dart2js cps: Use a global counter to generate hash codes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1311673009: dart2js cps: Use a global counter to generate hash codes. (Closed)

Created:
5 years, 3 months ago by asgerf

Modified:
5 years, 3 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

dart2js cps: Use a global counter to generate hash codes. This gives almost 30x compile-time speedup on ImagingGaussianBlurOnce. Based on profiling with Observatory, it seems to be a performance bug in how hash codes are stored on objects. The majority of time is spent in Object_GetHash, which does not compute a hash, but looks it up in a weak hash table in the VM. R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/82e95e3053b37cdd27494a723abe75d18709409a

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

asgerf

5 years, 3 months ago (2015-08-26 14:47:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
82e95e3053b37cdd27494a723abe75d18709409a (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages