Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 13116021: Fix docs.dart, which has been sad and neglected. (Closed)

Created:
7 years, 9 months ago by Andrei Mouravski
Modified:
7 years, 9 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix docs.dart, which has been sad and neglected. Committed: https://code.google.com/p/dart/source/detail?r=20587

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -21 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 3 chunks +24 lines, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +16 lines, -0 lines 0 comments Download
M tools/dom/docs/bin/docs.dart View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M tools/dom/docs/docs.json View 1 chunk +24 lines, -0 lines 0 comments Download
M tools/dom/docs/lib/docs.dart View 2 chunks +13 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Andrei Mouravski
7 years, 9 months ago (2013-03-27 20:09:47 UTC) #1
Emily Fortuna
lgtm. Poor docs.dart. So sad and neglected. :-) https://codereview.chromium.org/13116021/diff/1/tools/dom/docs/bin/docs.dart File tools/dom/docs/bin/docs.dart (right): https://codereview.chromium.org/13116021/diff/1/tools/dom/docs/bin/docs.dart#newcode23 tools/dom/docs/bin/docs.dart:23: print('Converted ...
7 years, 9 months ago (2013-03-27 21:21:47 UTC) #2
Andrei Mouravski
Committed patchset #3 manually as r20587 (presubmit successful).
7 years, 9 months ago (2013-03-27 21:47:12 UTC) #3
Andrei Mouravski
7 years, 9 months ago (2013-03-27 21:47:26 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/13116021/diff/1/tools/dom/docs/bin/docs.dart
File tools/dom/docs/bin/docs.dart (right):

https://codereview.chromium.org/13116021/diff/1/tools/dom/docs/bin/docs.dart#...
tools/dom/docs/bin/docs.dart:23: print('Converted HTML docs ${anyErrors ? "with
$anyErrors" : "without"}'
On 2013/03/27 21:21:47, Emily Fortuna wrote:
> if anyErrors is true, then wouldn't this print out:
> "Converted HTML docs with true errors." ? I think you want to get rid of that
> string interpolation of anyErrors

Done.

Powered by Google App Engine
This is Rietveld 408576698