Issue 1311393010: Cache more constants

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1311393010: Cache more constants (Closed)

Created:
5 years, 3 months ago by hausner

Modified:
5 years, 3 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Cache more constants BUG= R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/d0f408811ee81214be571a4bb4f641565569b9ea

Patch Set 2 : Add symbol constants to the cache #

Total comments: 1

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -8 lines)			Patch
	M	runtime/vm/parser.cc	View	1	4 chunks	+20 lines, -8 lines	1 comment	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

srdjan

lgtm https://codereview.chromium.org/1311393010/diff/20001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/1311393010/diff/20001/runtime/vm/parser.cc#newcode2611 runtime/vm/parser.cc:2611: GrowableArray<Field*>* initialized_fields) { Formatting looks weird here

5 years, 3 months ago (2015-09-03 23:07:02 UTC) #4

hausner

5 years, 3 months ago (2015-09-03 23:33:12 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
d0f408811ee81214be571a4bb4f641565569b9ea (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1311393010: Cache more constants (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add symbol constants to the cache #

Messages