Issue 1311353008: dart2js cps: Use a strictness flag on Branch instead of rewriting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1311353008: dart2js cps: Use a strictness flag on Branch instead of rewriting. (Closed)

Created:
5 years, 3 months ago by asgerf

Modified:
5 years, 3 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

dart2js cps: Use a strictness flag on Branch instead of rewriting. The unsugar pass no longer inserts `identical(_, true)` around every branching condition. Insead, the Branch node has a flag isStrictCheck denoting whether that check should be there. The `identical(_, true)` check is now inserted by the Tree IR builder. The identical nodes obstructed reasoning about branching conditions, in particular in redundant joint elimination and insertion of type refinement nodes. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/a1ddf508358f370f8b8e195e2809a72827195112

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+122 lines, -160 lines)			Patch
M	pkg/compiler/lib/src/cps_ir/cps_fragment.dart	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart	View	11 chunks	+33 lines, -33 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart	View	5 chunks	+24 lines, -29 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart	View	3 chunks	+3 lines, -10 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/redundant_join.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/type_propagation.dart	View	10 chunks	+36 lines, -20 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen/unsugar.dart	View	3 chunks	+1 line, -40 lines	0 comments	Download
M	pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart	View	4 chunks	+14 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

asgerf

5 years, 3 months ago (2015-09-01 12:42:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a1ddf508358f370f8b8e195e2809a72827195112 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages