Issue 1311323002: Modernize the style.

Issue 1311323002: Modernize the style. (Closed)

Created:
5 years, 4 months ago by nweiz

Modified:
5 years, 3 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/oauth2.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Modernize the style. R=rnystrom@google.com Committed: https://github.com/dart-lang/oauth2/commit/3f0b86f76c70237f2890fddaba8e48b3199a0e4b

Patch Set 1 #

Total comments: 2

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+186 lines, -199 lines)			Patch
M	lib/src/authorization_code_grant.dart	View	12 chunks	+73 lines, -51 lines	2 comments	Download
M	lib/src/authorization_exception.dart	View	1 chunk	+11 lines, -5 lines	0 comments	Download
M	lib/src/client.dart	View	6 chunks	+29 lines, -19 lines	0 comments	Download
M	lib/src/credentials.dart	View	7 chunks	+33 lines, -20 lines	0 comments	Download
M	lib/src/expiration_exception.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/src/handle_access_token_response.dart	View	7 chunks	+17 lines, -14 lines	0 comments	Download
M	lib/src/utils.dart	View	1 chunk	+5 lines, -44 lines	0 comments	Download
M	test/authorization_code_grant_test.dart	View	4 chunks	+12 lines, -22 lines	0 comments	Download
M	test/client_test.dart	View	4 chunks	+3 lines, -14 lines	0 comments	Download
M	test/credentials_test.dart	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	test/utils.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	test/utils_test.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM! https://codereview.chromium.org/1311323002/diff/1/lib/src/authorization_code_grant.dart File lib/src/authorization_code_grant.dart (right): https://codereview.chromium.org/1311323002/diff/1/lib/src/authorization_code_grant.dart#newcode256 lib/src/authorization_code_grant.dart:256: class _State { I think you might actually ...

5 years, 3 months ago (2015-08-25 21:49:10 UTC) #2

nweiz

Committed patchset #1 (id:1) manually as 3f0b86f76c70237f2890fddaba8e48b3199a0e4b (presubmit successful).

5 years, 3 months ago (2015-08-25 22:04:22 UTC) #3

nweiz

5 years, 3 months ago (2015-08-25 22:06:54 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/1311323002/diff/1/lib/src/authorization_code_...
File lib/src/authorization_code_grant.dart (right):

https://codereview.chromium.org/1311323002/diff/1/lib/src/authorization_code_...
lib/src/authorization_code_grant.dart:256: class _State {
On 2015/08/25 21:49:10, Bob Nystrom wrote:
> I think you might actually be able to use an enum for this. (!)

Technically yes, but it makes debugging prints really painful and it's
inconsistent with our general style.

Expand Messages | Collapse Messages