Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 1311123002: Revert "Remove SendResolver.computeSendStructure." (Closed)

Created:
5 years, 4 months ago by Johnni Winther
Modified:
5 years, 4 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Remove SendResolver.computeSendStructure." This reverts commit 4013a9aae54ee60d344247d295b750f370ce2417. BUG= Committed: https://github.com/dart-lang/sdk/commit/73a49a5ddbf7bc989adfd07668db1d29c98f91f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+556 lines, -64 lines) Patch
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 chunk +3 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 4 chunks +17 lines, -28 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 2 chunks +535 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_data.dart View 3 chunks +0 lines, -29 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
TBR
5 years, 4 months ago (2015-08-24 11:46:07 UTC) #2
floitsch
LGTM.
5 years, 4 months ago (2015-08-24 11:46:36 UTC) #3
Johnni Winther
5 years, 4 months ago (2015-08-24 11:46:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
73a49a5ddbf7bc989adfd07668db1d29c98f91f2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698