Issue 1310483004: Redo "Inline single-use local closures."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1310483004: Redo "Inline single-use local closures." (Closed)

Created:
5 years, 3 months ago by sra1

Modified:
5 years, 3 months ago

Reviewers:
asgerf

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Redo "Inline single-use local closures." Updated js_backend_cps_ir_closures_test.dart Made two variants of tests that were changed by inlining: 1. Same source, showing inlined code. 2. Source with escaping closure to avoid inlining. Committed: https://github.com/dart-lang/sdk/commit/68f1ea3f84f079f3ec91d9246628719d7848984e

Patch Set 1 #

Patch Set 2 : test updates #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+169 lines, -5 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/type_propagation.dart	View		5 chunks	+91 lines, -1 line	0 comments	Download
	M	tests/compiler/dart2js/js_backend_cps_ir_closures_test.dart	View	1	4 chunks	+78 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sra1

Committed patchset #2 (id:20001) manually as 68f1ea3f84f079f3ec91d9246628719d7848984e (presubmit successful).

5 years, 3 months ago (2015-09-02 02:51:07 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages