Hoist tokenizing RegExps out.

Hoist tokenizing RegExps out.

R=nweiz@google.com

Committed: https://github.com/dart-lang/yaml/commit/b7bb9425991739a81ad27ddb1fdbc2a2b4fbd3a7

[Bob Nystrom, 2015-09-02 00:00:25]

rnystrom@google.com changed reviewers:
+ nweiz@google.com

[Bob Nystrom, 2015-09-02 00:00:25]

This also has the benchmark changes. I'll rebase those out after that lands.

[nweiz, 2015-09-02 00:07:57]

lgtm

https://codereview.chromium.org/1310423004/diff/1/lib/src/loader.dart
File lib/src/loader.dart (right):

https://codereview.chromium.org/1310423004/diff/1/lib/src/loader.dart#newcode24
lib/src/loader.dart:24: final _nanRegExp = new RegExp(r"^\.(nan|NaN|NAN)$");
All these symbols are blurring together. You don't have to document all these,
but please do separate them with whitespace.

https://codereview.chromium.org/1310423004/diff/1/lib/src/loader.dart#newcode196
lib/src/loader.dart:196: // TODO(nweiz): stop using regexps.
You can remove this.

[Bob Nystrom, 2015-09-02 00:13:16]

Committed patchset #2 (id:20001) manually as
b7bb9425991739a81ad27ddb1fdbc2a2b4fbd3a7 (presubmit successful).

[Bob Nystrom, 2015-09-02 00:13:32]

https://codereview.chromium.org/1310423004/diff/1/lib/src/loader.dart
File lib/src/loader.dart (right):

https://codereview.chromium.org/1310423004/diff/1/lib/src/loader.dart#newcode24
lib/src/loader.dart:24: final _nanRegExp = new RegExp(r"^\.(nan|NaN|NAN)$");
On 2015/09/02 00:07:57, nweiz wrote:
> All these symbols are blurring together. You don't have to document all these,
> but please do separate them with whitespace.

Commented.

https://codereview.chromium.org/1310423004/diff/1/lib/src/loader.dart#newcode196
lib/src/loader.dart:196: // TODO(nweiz): stop using regexps.
On 2015/09/02 00:07:56, nweiz wrote:
> You can remove this.

Done.