Minor cleanup in preparation for removal of allocation in new space, and removal of an 'optimizatio…

Minor cleanup in preparation for removal of allocation in new space, and removal of an 'optimization'

BUG=
R=hausner@google.com

Committed: https://github.com/dart-lang/sdk/commit/fcea0077cc84389539d4a3944adec1dcb7722e69

[srdjan, 2015-08-24 19:54:32]

srdjan@google.com changed reviewers:
+ hausner@google.com

[hausner, 2015-08-24 20:13:18]

lgtm

https://codereview.chromium.org/1310383002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1310383002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:7234: parameters[i +
params.num_fixed_parameters].default_value;
Maybe give a symbolic name to the offset in the parameters array?

const int first_opt_param_offset = params.num_fixed_parameters;
...
const Object* default_value =  parameters[i +
first_opt_param_offset].default_value;

[srdjan, 2015-08-24 20:21:56]

https://codereview.chromium.org/1310383002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1310383002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:7234: parameters[i +
params.num_fixed_parameters].default_value;
On 2015/08/24 20:13:18, hausner wrote:
> Maybe give a symbolic name to the offset in the parameters array?
> 
> const int first_opt_param_offset = params.num_fixed_parameters;
> ...
> const Object* default_value =  parameters[i +
> first_opt_param_offset].default_value;
> 

Done.

[srdjan, 2015-08-24 20:40:43]

Committed patchset #2 (id:20001) manually as
fcea0077cc84389539d4a3944adec1dcb7722e69 (presubmit successful).