Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1310263003: Reformat code to minimize churn (Closed)

Created:
5 years, 3 months ago by Brian Wilkerson
Modified:
5 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+657 lines, -383 lines) Patch
M pkg/analysis_server/benchmark/integration/driver.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/benchmark/integration/instrumentation_input_converter.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/benchmark/integration/local_runner.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M pkg/analysis_server/benchmark/integration/main.dart View 4 chunks +13 lines, -8 lines 0 comments Download
M pkg/analysis_server/benchmark/integration/operation.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_logger.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_completion.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_server.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/get_handler.dart View 15 chunks +79 lines, -57 lines 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 9 chunks +32 lines, -23 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/arglist_contributor.dart View 3 chunks +21 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/common_usage_computer.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/completion_dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/completion_manager.dart View 5 chunks +0 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart View 3 chunks +8 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 2 chunks +14 lines, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/imported_reference_contributor.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/local_suggestion_builder.dart View 2 chunks +11 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart View 7 chunks +25 lines, -14 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/assist.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/namespace.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/statement_analyzer.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/index/local_file_index.dart View 1 chunk +7 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/index/store/split_store.dart View 2 chunks +8 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/extract_local.dart View 2 chunks +7 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/extract_method.dart View 3 chunks +10 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/inline_method.dart View 1 chunk +8 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/move_file.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/refactoring.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart View 3 chunks +24 lines, -12 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_import.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart View 2 chunks +8 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/search/search_engine_internal.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 2 chunks +15 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/status/get_handler.dart View 12 chunks +63 lines, -49 lines 0 comments Download
M pkg/analysis_server/lib/src/status/tree_writer.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/utilities/change_builder_dart.dart View 5 chunks +26 lines, -11 lines 0 comments Download
M pkg/analysis_server/lib/utilities/change_builder_dart.dart View 4 chunks +24 lines, -10 lines 0 comments Download
M pkg/analysis_server/test/completion_test.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/completion_test_support.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 5 chunks +34 lines, -14 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_tests.dart View 7 chunks +25 lines, -13 lines 0 comments Download
M pkg/analysis_server/test/mock_sdk.dart View 5 chunks +25 lines, -11 lines 0 comments Download
M pkg/analysis_server/test/services/completion/arglist_contributor_test.dart View 11 chunks +34 lines, -12 lines 0 comments Download
M pkg/analysis_server/test/services/completion/local_reference_contributor_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/abstract_refactoring.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/codegen_dart_protocol.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_inttest_methods.dart View 2 chunks +5 lines, -6 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_matchers.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_tools.dart View 6 chunks +16 lines, -11 lines 0 comments Download
M pkg/analysis_server/tool/spec/from_html.dart View 3 chunks +4 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/text_formatter.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/to_html.dart View 6 chunks +18 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
This contains no non-formatting changes. I think I avoided formatting any of the generated files.
5 years, 3 months ago (2015-09-09 15:12:16 UTC) #2
scheglov
LGTM
5 years, 3 months ago (2015-09-09 15:15:19 UTC) #3
Brian Wilkerson
5 years, 3 months ago (2015-09-09 15:19:24 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
42d1d4532d631a88fdafcb8d82d14851e669cb43 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698