Issue 1310183014: Generalize lookup-maps to support other const keys

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1310183014: Generalize lookup-maps to support other const keys (Closed)

Created:
5 years, 3 months ago by Siggi Cherem (dart-lang)

Modified:
5 years, 3 months ago

Reviewers:
herhut, sra1

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+252 lines, -127 lines)			Patch
M	pkg/compiler/lib/src/js_backend/backend.dart	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart	View	11 chunks	+97 lines, -53 lines	0 comments	Download
M	tests/compiler/dart2js/lookup_map_test.dart	View	12 chunks	+148 lines, -64 lines	0 comments	Download
A +	tests/compiler/dart2js_extra/lookup_map/reachable_data2_test.dart	View	1 chunk	+6 lines, -5 lines	0 comments	Download

Total messages: 5 (2 generated)

Siggi Cherem (dart-lang)

Part 2 :) After this, my plan is to make sure we support mirrors correctly ...

5 years, 3 months ago (2015-09-03 01:12:10 UTC) #3

Siggi Cherem (dart-lang)

5 years, 3 months ago (2015-09-03 15:41:16 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:20001) manually as
dc9bcce7781bf78a7d8da168f4a983d7a0e6b022 (presubmit successful).