Switch from Google charts to Charted

Switch from Google charts to Charted

R=turnidge@google.com

Committed: https://github.com/dart-lang/sdk/commit/95513b0a1d13e91b6557ef351e9fb475add62aa3

[Cutch, 2015-08-24 13:49:23]

johnmccutchan@google.com changed reviewers:
+ turnidge@google.com

[turnidge, 2015-09-16 17:00:28]

Here are my comments from a first pass.  This would be lgtm, but I want to look
at the final code once the charted bugs land.

https://codereview.chromium.org/1310153002/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/heap_profile.dart (right):

https://codereview.chromium.org/1310153002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/heap_profile.dart:62:
_oldPieChartRows.add(['External', 0]);
Couldl have a helper:

initBlahPieChartRows(_newPieChartRows)

Your call

https://codereview.chromium.org/1310153002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/heap_profile.dart:96: var series = new
ChartSeries(id, [1], new PieChartRenderer());
Just curious, what is a ChartSeries?

https://codereview.chromium.org/1310153002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/heap_profile.dart:162:
_oldPieChartRows[2][1] = isolate.oldSpace.external;
Consider naming the indices: 0 -> kUsedIdx, 1 -> kFreeIdx, etc.

Could have a helper function for setting this up:

_initMyPieChartRows(_newPieChartRows, isolate.newSpace)

Your call.

[Cutch, 2015-09-28 20:58:17]

We are now unblocked on charted and this is ready to land.

PTAL

https://codereview.chromium.org/1310153002/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/heap_profile.dart (right):

https://codereview.chromium.org/1310153002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/heap_profile.dart:62:
_oldPieChartRows.add(['External', 0]);
On 2015/09/16 17:00:28, turnidge wrote:
> Couldl have a helper:
> 
> initBlahPieChartRows(_newPieChartRows)
> 
> Your call

Done.

https://codereview.chromium.org/1310153002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/heap_profile.dart:96: var series = new
ChartSeries(id, [1], new PieChartRenderer());
On 2015/09/16 17:00:28, turnidge wrote:
> Just curious, what is a ChartSeries?

It is "one or more columns of ChartData rendered together".

https://codereview.chromium.org/1310153002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/heap_profile.dart:162:
_oldPieChartRows[2][1] = isolate.oldSpace.external;
On 2015/09/16 17:00:28, turnidge wrote:
> Consider naming the indices: 0 -> kUsedIdx, 1 -> kFreeIdx, etc.
> 
> Could have a helper function for setting this up:
> 
> _initMyPieChartRows(_newPieChartRows, isolate.newSpace)
> 
> Your call.

Done.

[turnidge, 2015-09-29 18:33:49]

lgtm

[Cutch, 2015-09-29 19:59:10]

Committed patchset #5 (id:80001) manually as
95513b0a1d13e91b6557ef351e9fb475add62aa3 (presubmit successful).