Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1310093003: analyzer version to 0.26.1+1 (Closed)

Created:
5 years, 4 months ago by devoncarew
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M pkg/analyzer/CHANGELOG.md View 1 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
devoncarew
5 years, 4 months ago (2015-08-23 22:51:47 UTC) #2
Brian Wilkerson
LGTM
5 years, 4 months ago (2015-08-24 00:02:09 UTC) #3
Paul Berry
lgtm with changes noted below https://codereview.chromium.org/1310093003/diff/1/pkg/analyzer/CHANGELOG.md File pkg/analyzer/CHANGELOG.md (right): https://codereview.chromium.org/1310093003/diff/1/pkg/analyzer/CHANGELOG.md#newcode3 pkg/analyzer/CHANGELOG.md:3: * Made the compile ...
5 years, 4 months ago (2015-08-24 14:10:46 UTC) #4
pquitslund
FWIW, lgtm2 (w/ Paul's changes).
5 years, 4 months ago (2015-08-24 14:28:12 UTC) #5
devoncarew
On 2015/08/24 14:28:12, pquitslund wrote: > FWIW, lgtm2 (w/ Paul's changes). Thanks! Changelog updated.
5 years, 4 months ago (2015-08-24 15:07:08 UTC) #6
devoncarew
5 years, 4 months ago (2015-08-24 15:08:57 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
a910b6ca702aefd6c969d83ad31195ebee6ee41d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698