Issue 131003015: Revert "Deal with intercepted fields in the InstanceMirror.getField optimizations."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 131003015: Revert "Deal with intercepted fields in the InstanceMirror.getField optimizations." (Closed)

Created:
6 years, 10 months ago by kasperl

Modified:
6 years, 10 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Deal with intercepted fields in the InstanceMirror.getField optimizations." This reverts r32236 in an attempt to figure out if this is the cause of the redness on the dart2js build bots that I cannot reproduce locally. R=floitsch@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=32243

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -69 lines)			Patch
	M	sdk/lib/_internal/lib/js_mirrors.dart	View		4 chunks	+17 lines, -69 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

Committed patchset #1 manually as r32243 (presubmit successful).

6 years, 10 months ago (2014-02-03 12:54:28 UTC) #2

floitsch

6 years, 10 months ago (2014-02-03 13:18:04 UTC) #4

Message was sent while issue was closed.

LGTM. interesting.
I had already pinged Florian Schneider, since this looks like a VM crash.

Expand Messages | Collapse Messages