Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1309813009: dart2js CPS: Do not transform unreachable branches. (Closed)

Created:
5 years, 3 months ago by Kevin Millikin (Google)
Modified:
5 years, 3 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js CPS: Do not transform unreachable branches. After type propagation, avoid transforming unreachable branches by explicitly replacing them with Unreachable. Also use the abstract boolean value rather than the concrete constant value for branches, just as was already done for type tests and casts. R=asgerf@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1e4469c14464f7dcadcf3d9f92bac6f4a2c96fc6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -19 lines) Patch
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 4 chunks +18 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Google)
Ideally we'd be able to assert that a continuation body is Unreachable exactly when the ...
5 years, 3 months ago (2015-08-28 09:12:12 UTC) #1
asgerf
LGTM.
5 years, 3 months ago (2015-08-28 10:18:24 UTC) #2
Kevin Millikin (Google)
5 years, 3 months ago (2015-08-28 11:10:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1e4469c14464f7dcadcf3d9f92bac6f4a2c96fc6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698