Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1309523002: GrowableObjectArray -> GrowableArray for parsing type arguments (Closed)

Created:
5 years, 4 months ago by srdjan
Modified:
5 years, 4 months ago
Reviewers:
koda, hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

GrowableObjectArray -> GrowableArray for parsing type arguments BUG= R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/14be219d84e2b8a99c59356b956465de22bd45f0

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M runtime/vm/parser.cc View 6 chunks +11 lines, -13 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
srdjan
5 years, 4 months ago (2015-08-20 22:45:21 UTC) #2
hausner
lgtm
5 years, 4 months ago (2015-08-20 22:49:50 UTC) #3
srdjan
Committed patchset #1 (id:1) manually as 14be219d84e2b8a99c59356b956465de22bd45f0 (presubmit successful).
5 years, 4 months ago (2015-08-20 22:55:30 UTC) #4
koda
DBC https://codereview.chromium.org/1309523002/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/1309523002/diff/1/runtime/vm/parser.cc#newcode5213 runtime/vm/parser.cc:5213: GrowableArray<AbstractType*> type_parameters_array; Consider passing in Z and a ...
5 years, 4 months ago (2015-08-21 00:22:02 UTC) #6
srdjan
5 years, 4 months ago (2015-08-21 16:40:34 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1309523002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1309523002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:5213: GrowableArray<AbstractType*> type_parameters_array;
On 2015/08/21 00:22:02, koda wrote:
> Consider passing in Z and a reasonable initial capacity (2?)

Thanks, will add it in the next CL.

Powered by Google App Engine
This is Rietveld 408576698