Add a hacky hook to override the loader behavior.

Add a hacky hook to override the loader behavior.

This is specifically to allow Sky to get sky_shell support into the test
runner immediately. It's temporary; it'll last until we land proper
plugin support.

See #320

R=rnystrom@google.com

Committed: https://github.com/dart-lang/test/commit/f8f698f0507ce8c0dcdd3d6cc4a55a9ca6c39c60

[nweiz, 2015-08-20 21:22:14]

nweiz@google.com changed reviewers:
+ rnystrom@google.com

[Bob Nystrom, 2015-08-20 22:04:47]

https://codereview.chromium.org/1309493002/diff/1/lib/src/runner/loader.dart
File lib/src/runner/loader.dart (right):

https://codereview.chromium.org/1309493002/diff/1/lib/src/runner/loader.dart#...
lib/src/runner/loader.dart:44: static LoadVMFileHook loadVMFileHook;
Maybe put this in a separate scary-named library?
test/experimental_loader_hack_oh_god_what_have_i_done.dart?

https://codereview.chromium.org/1309493002/diff/1/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/1309493002/diff/1/pubspec.yaml#newcode2
pubspec.yaml:2: version: 0.12.4+5
What do you think of making this a prerelease?

[nweiz, 2015-08-20 22:18:57]

Code review changes

[nweiz, 2015-08-20 22:19:02]

https://codereview.chromium.org/1309493002/diff/1/lib/src/runner/loader.dart
File lib/src/runner/loader.dart (right):

https://codereview.chromium.org/1309493002/diff/1/lib/src/runner/loader.dart#...
lib/src/runner/loader.dart:44: static LoadVMFileHook loadVMFileHook;
On 2015/08/20 22:04:47, Bob Nystrom wrote:
> Maybe put this in a separate scary-named library?
> test/experimental_loader_hack_oh_god_what_have_i_done.dart?

Done. Not attaching it to Loader will also make life easier once we expose it in
a test_runner package.

https://codereview.chromium.org/1309493002/diff/1/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/1309493002/diff/1/pubspec.yaml#newcode2
pubspec.yaml:2: version: 0.12.4+5
On 2015/08/20 22:04:47, Bob Nystrom wrote:
> What do you think of making this a prerelease?

I don't think that buys us anything. We'd release a stable version with it as
soon as we got another bug fix or whatever anyway.

[Bob Nystrom, 2015-08-20 22:27:38]

lgtm

https://codereview.chromium.org/1309493002/diff/20001/lib/src/runner/hack_loa...
File lib/src/runner/hack_load_vm_file_hook.dart (right):

https://codereview.chromium.org/1309493002/diff/20001/lib/src/runner/hack_loa...
lib/src/runner/hack_load_vm_file_hook.dart:17: static loadVMFileHook;
"static" -> "LoadVMFileHook".

[nweiz, 2015-08-21 00:07:58]

Code review changes

[nweiz, 2015-08-21 00:08:09]

https://codereview.chromium.org/1309493002/diff/20001/lib/src/runner/hack_loa...
File lib/src/runner/hack_load_vm_file_hook.dart (right):

https://codereview.chromium.org/1309493002/diff/20001/lib/src/runner/hack_loa...
lib/src/runner/hack_load_vm_file_hook.dart:17: static loadVMFileHook;
On 2015/08/20 22:27:38, Bob Nystrom wrote:
> "static" -> "LoadVMFileHook".

Done.

[nweiz, 2015-08-21 00:10:28]

Committed patchset #3 (id:40001) manually as
f8f698f0507ce8c0dcdd3d6cc4a55a9ca6c39c60 (presubmit successful).