Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 13094013: Fix bug 9239 by always evaluating the receiver before the value in an instance SendSet. (Closed)

Created:
7 years, 9 months ago by ngeoffray
Modified:
7 years, 9 months ago
Reviewers:
erikcorry, kasperl, sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix bug 9239 by always evaluating the receiver before the value in an instance SendSet. Committed: https://code.google.com/p/dart/source/detail?r=20649

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -8 lines) Patch
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 4 chunks +13 lines, -8 lines 0 comments Download
A tests/language/getter_setter_order_test.dart View 1 1 chunk +92 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ngeoffray
7 years, 9 months ago (2013-03-26 17:40:10 UTC) #1
sra1
I think it is lgtm but I do find the push/pop pattern a bit confusing ...
7 years, 9 months ago (2013-03-26 21:45:58 UTC) #2
ngeoffray
Thanks Stephen. https://codereview.chromium.org/13094013/diff/2001/tests/language/getter_setter_order_test.dart File tests/language/getter_setter_order_test.dart (right): https://codereview.chromium.org/13094013/diff/2001/tests/language/getter_setter_order_test.dart#newcode74 tests/language/getter_setter_order_test.dart:74: } On 2013/03/26 21:45:58, sra1 wrote: > ...
7 years, 9 months ago (2013-03-28 11:31:03 UTC) #3
ngeoffray
7 years, 9 months ago (2013-03-28 21:46:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20649 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698