Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1309373005: Allow individual unicode surrogate strings (Closed)

Created:
5 years, 3 months ago by Alan Knight
Modified:
5 years, 3 months ago
Reviewers:
terry, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add a test #

Patch Set 3 : Also fix unicode tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -38 lines) Patch
M runtime/vm/dart_api_impl_test.cc View 1 2 2 chunks +26 lines, -4 lines 0 comments Download
M runtime/vm/unicode.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M runtime/vm/unicode_test.cc View 1 2 16 chunks +37 lines, -30 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Alan Knight
BUG = https://github.com/dart-lang/sdk/issues/24248
5 years, 3 months ago (2015-08-31 22:37:00 UTC) #2
siva
Could you add a test case that exercises this path. Thanks.
5 years, 3 months ago (2015-09-01 17:12:09 UTC) #3
Alan Knight
Added test. PTAL.
5 years, 3 months ago (2015-09-02 17:50:26 UTC) #4
siva
lgtm
5 years, 3 months ago (2015-09-02 20:32:57 UTC) #5
Alan Knight
Committed patchset #2 (id:20001) manually as 6ba411ffc9f0122855054e5f3056c7d296c2161d (presubmit successful).
5 years, 3 months ago (2015-09-02 21:46:33 UTC) #6
Alan Knight
Also fixed the unicode tests that were failing.
5 years, 3 months ago (2015-09-04 23:45:59 UTC) #7
Alan Knight
5 years, 3 months ago (2015-09-15 16:18:57 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:30001) manually as
5760cf1f1c5a448fe31d787989989212f755e62c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698