Stop propagating return types for top-level function declarations

Stop propagating return types for top-level function declarations

R=paulberry@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/5efe30d4582b25f99fa0aee52abe11bc9b3660ff

[Brian Wilkerson, 2015-09-08 18:21:01]

brianwilkerson@google.com changed reviewers:
+ paulberry@google.com, scheglov@google.com

[scheglov, 2015-09-08 18:26:12]

LGTM, but I wonder whether return type is still propagated in closures.

What type has "p2" with this change?

-----------
import 'dart:async';

class A {
  Future<int> mmm() async {
    return 42;
  }

  a() {
    mmm().then((p1) {
      return p1.toString();
    }).then((p2) {
      print(p2);
    });
  }
}
-----------

[Paul Berry, 2015-09-08 19:55:08]

Assuming Konstantin's concern is addressed, lgtm.

[Brian Wilkerson, 2015-09-08 20:14:28]

I added the test case, and the test passed. I've uploaded the test so you can
make sure I got it right.

[Brian Wilkerson, 2015-09-08 20:14:41]

Committed patchset #2 (id:20001) manually as
5efe30d4582b25f99fa0aee52abe11bc9b3660ff (presubmit successful).