Issue 13090002: Free names of inputs of an instruction that is generate at use site. An input of an instruction tha…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13090002: Free names of inputs of an instruction that is generate at use site. An input of an instruction tha… (Closed)

Created:
7 years, 9 months ago by ngeoffray

Modified:
7 years, 8 months ago

Reviewers:
erikcorry, Johnni Winther, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Free names of inputs of an instruction that is generate at use site. An input of an instruction that is generate at use site dies at the user of that instruction, not the instruction itself. Committed: https://code.google.com/p/dart/source/detail?r=20724

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -8 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart	View	1	2 chunks	+19 lines, -7 lines	0 comments	Download
	M	tests/compiler/dart2js/ssa_phi_codegen_test.dart	View	1	2 chunks	+13 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

https://codereview.chromium.org/13090002/diff/1/tests/co19/co19-dart2js.status File tests/co19/co19-dart2js.status (left): https://codereview.chromium.org/13090002/diff/1/tests/co19/co19-dart2js.status#oldcode716 tests/co19/co19-dart2js.status:716: Language/14_Types/4_Interface_Types_A11_t02: Crash # Issue 8557 The bug is a ...

7 years, 9 months ago (2013-03-26 11:29:02 UTC) #1

ngeoffray

7 years, 8 months ago (2013-04-01 09:40:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r20724 (presubmit successful).

Expand Messages | Collapse Messages