Fix two memory leaks in SecureSocket.

Fix two memory leaks in SecureSocket.

BUG=
R=sgjesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/2a091441a130e599af0606af4a8b3451435e52f5

[Bill Hesse, 2015-09-02 14:52:02]

whesse@google.com changed reviewers:
+ sgjesse@google.com

[Bill Hesse, 2015-09-02 14:52:02]

Includes a change to the comment documenting Dart_NewWeakPersistentHandle.  It
cannot return an
error handle, since that would be a type violation.
It returns NULL, and that only in one case.  It
basically does not return an error, and only fails fatally.

[Søren Gjesse, 2015-09-02 16:24:31]

sgjesse@google.com changed reviewers:
+ iposva@google.com

[Søren Gjesse, 2015-09-02 16:24:31]

lgtm

https://codereview.chromium.org/1308953007/diff/1/runtime/bin/secure_socket.cc
File runtime/bin/secure_socket.cc (left):

https://codereview.chromium.org/1308953007/diff/1/runtime/bin/secure_socket.c...
runtime/bin/secure_socket.cc:317: // when the object is GC'd.  Also free the
alpn_select_cb data pointer,
How about the alpn_select_cb data pointer mentioned in this TODO as well?

https://codereview.chromium.org/1308953007/diff/1/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/1308953007/diff/1/runtime/include/dart_api.h#...
runtime/include/dart_api.h:479: Returns NULL if and only if the callback is
NULL.
Please check this with the VM team.

[Bill Hesse, 2015-09-03 08:43:22]

Committed patchset #2 (id:20001) manually as
2a091441a130e599af0606af4a8b3451435e52f5 (presubmit successful).

[Bill Hesse, 2015-09-03 08:47:00]

https://codereview.chromium.org/1308953007/diff/1/runtime/bin/secure_socket.cc
File runtime/bin/secure_socket.cc (left):

https://codereview.chromium.org/1308953007/diff/1/runtime/bin/secure_socket.c...
runtime/bin/secure_socket.cc:317: // when the object is GC'd.  Also free the
alpn_select_cb data pointer,
On 2015/09/02 16:24:31, Søren Gjesse wrote:
> How about the alpn_select_cb data pointer mentioned in this TODO as well?

The TODO is moved below.  The issue is harder to resolve, since it uses an
internal member of the struct, and also should free it when it is reset to a
different value (but not the same value).  It is more important to get this
major leak fixed.

https://codereview.chromium.org/1308953007/diff/1/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/1308953007/diff/1/runtime/include/dart_api.h#...
runtime/include/dart_api.h:479: Returns NULL if and only if the callback is
NULL.
On 2015/09/02 16:24:31, Søren Gjesse wrote:
> Please check this with the VM team.

They haven't looked at it, so removing it.