Issue 1308803002: Make InferrerVisitor implement SemanticSendVisitor directly and delete ResolvedVisitor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1308803002: Make InferrerVisitor implement SemanticSendVisitor directly and delete ResolvedVisitor. (Closed)

Created:
5 years, 4 months ago by Johnni Winther

Modified:
5 years, 4 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Make InferrerVisitor implement SemanticSendVisitor directly and delete ResolvedVisitor. BUG= R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/bda8db4785669c54c8ea1bedc664b684dc925778

Patch Set 1 #

Total comments: 1

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+94 lines, -909 lines)			Patch
M	pkg/compiler/lib/src/inferrer/inferrer_visitor.dart	View	9 chunks	+73 lines, -9 lines	1 comment	Download
M	pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart	View	5 chunks	+16 lines, -25 lines	0 comments	Download
M	pkg/compiler/lib/src/resolution/semantic_visitor.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
D	pkg/compiler/lib/src/resolved_visitor.dart	View	1 chunk	+0 lines, -873 lines	0 comments	Download
M	tests/compiler/dart2js/analyze_unused_dart2js_test.dart	View	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Johnni Winther

https://codereview.chromium.org/1308803002/diff/1/pkg/compiler/lib/src/inferrer/inferrer_visitor.dart File pkg/compiler/lib/src/inferrer/inferrer_visitor.dart (right): https://codereview.chromium.org/1308803002/diff/1/pkg/compiler/lib/src/inferrer/inferrer_visitor.dart#newcode883 pkg/compiler/lib/src/inferrer/inferrer_visitor.dart:883: @override These are not used, yet.

5 years, 4 months ago (2015-08-21 10:55:12 UTC) #2

Johnni Winther

5 years, 4 months ago (2015-08-21 12:11:40 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bda8db4785669c54c8ea1bedc664b684dc925778 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages