Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Issue 1308773005: Fix hostname checking problem in SecureSocket (Closed)

Created:
5 years, 3 months ago by Bill Hesse
Modified:
5 years, 3 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix hostname checking problem in SecureSocket BUG=https://github.com/dart-lang/sdk/issues/24071 R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/db97aa7e9695566a780cc5ea570afec700e420d1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M runtime/bin/secure_socket.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M tests/standalone/io/certificates/README View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Bill Hesse
5 years, 3 months ago (2015-08-27 17:59:48 UTC) #2
Søren Gjesse
lgtm
5 years, 3 months ago (2015-08-28 06:20:04 UTC) #3
Bill Hesse
5 years, 3 months ago (2015-08-28 08:08:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
db97aa7e9695566a780cc5ea570afec700e420d1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698