Issue 1308743006: Revert "This is a fixed up version of:"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1308743006: Revert "This is a fixed up version of:" (Closed)

Created:
5 years, 3 months ago by ricow1

Modified:
5 years, 3 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "This is a fixed up version of:" This reverts commit dd7767d95eda87054844e0b24ebd2ce9b04354bb. This made the analyzer fail: http://build.chromium.org/p/client.dart/builders/analyzer_experimental-linux-release-be/builds/3418/ Please note that this is just not the new test (which I would just have suppressed) It seems that in --checked --host-checked mode we see a range of new failures, because of the change to flags. It also made dart2js fail on the new tests Ivan: Will you look into this with the analyzer people? R=iposva@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/02320ff26e1afdfdeca2800ef8ad5c63a3f7c64b

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -24 lines)			Patch
M	runtime/vm/parser.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/assertion_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
D	tests/standalone/no_assert_test.dart	View	1 chunk	+0 lines, -16 lines	0 comments	Download
M	tools/testing/dart/compiler_configuration.dart	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

ricow1

5 years, 3 months ago (2015-09-07 06:45:22 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
02320ff26e1afdfdeca2800ef8ad5c63a3f7c64b (presubmit successful).