Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1308713004: Fix warning in element_handle.dart. (Closed)

Created:
5 years, 4 months ago by Paul Berry
Modified:
5 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix warning in element_handle.dart. Commit 4bd6b4b0485023785ebe89fae59df3d33495ca3b added the abstract method appendToWithoutDelimiters() to ParameterElement, which is implemented in ParameterElementMixin. However, one derived class was not updated to make use of the new mixin: ParameterElementHandle. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/9d6898104e7a58ed4a7f87bd066feb630d485156

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pkg/analyzer/lib/src/generated/element_handle.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 4 months ago (2015-08-25 19:38:01 UTC) #2
Brian Wilkerson
LGTM. Sorry I missed that.
5 years, 4 months ago (2015-08-25 20:20:50 UTC) #3
Paul Berry
5 years, 4 months ago (2015-08-25 20:27:30 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
9d6898104e7a58ed4a7f87bd066feb630d485156 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698