Issue 1308163004: Async-ify.

Issue 1308163004: Async-ify. (Closed)

Created:
5 years, 3 months ago by nweiz

Modified:
5 years, 3 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/oauth2.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Async-ify. R=rnystrom@google.com Committed: https://github.com/dart-lang/oauth2/commit/0589889f9fadc8d66d3e24364dfd54e17f416572

Patch Set 1 #

Total comments: 2

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+200 lines, -217 lines)			Patch
M	README.md	View	1 chunk	+47 lines, -40 lines	0 comments	Download
M	lib/src/authorization_code_grant.dart	View	4 chunks	+54 lines, -57 lines	2 comments	Download
M	lib/src/client.dart	View	2 chunks	+39 lines, -44 lines	0 comments	Download
M	lib/src/credentials.dart	View	1 chunk	+32 lines, -35 lines	0 comments	Download
M	lib/src/utils.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/client_test.dart	View	9 chunks	+17 lines, -24 lines	0 comments	Download
M	test/credentials_test.dart	View	3 chunks	+10 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM! https://codereview.chromium.org/1308163004/diff/1/lib/src/authorization_code_grant.dart File lib/src/authorization_code_grant.dart (right): https://codereview.chromium.org/1308163004/diff/1/lib/src/authorization_code_grant.dart#newcode165 lib/src/authorization_code_grant.dart:165: } else if (_state == _FINISHED_STATE) { Nit, ...

5 years, 3 months ago (2015-08-24 21:36:52 UTC) #2

nweiz

https://codereview.chromium.org/1308163004/diff/1/lib/src/authorization_code_grant.dart File lib/src/authorization_code_grant.dart (right): https://codereview.chromium.org/1308163004/diff/1/lib/src/authorization_code_grant.dart#newcode165 lib/src/authorization_code_grant.dart:165: } else if (_state == _FINISHED_STATE) { On 2015/08/24 ...

5 years, 3 months ago (2015-08-24 23:58:34 UTC) #3

nweiz

5 years, 3 months ago (2015-08-24 23:58:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0589889f9fadc8d66d3e24364dfd54e17f416572 (presubmit successful).

Expand Messages | Collapse Messages