Make default_parameter_values a ZoneGrowableArray instead of an array in new space

Make default_parameter_values a ZoneGrowableArray instead of an array in new space

BUG=
R=hausner@google.com

Committed: https://github.com/dart-lang/sdk/commit/304dc3486f92cf7e81f9bf1e089b6da9b8047981

[srdjan, 2015-08-24 22:41:50]

srdjan@google.com changed reviewers:
+ hausner@google.com

[hausner, 2015-08-24 23:32:39]

lgtm

LGTM w/comment

You are now using a growable array where a fixed size array was used. The number
of default values is known after the formal parameters are parsed.

As discussed offline, you'll look into eliminating the default_values parameter.
The parser can, when it has parsed the formal parameters of a function, directly
set the default values in parsed_function().

https://codereview.chromium.org/1307943008/diff/20001/runtime/vm/parser.cc
File runtime/vm/parser.cc (left):

https://codereview.chromium.org/1307943008/diff/20001/runtime/vm/parser.cc#ol...
runtime/vm/parser.cc:7230: *default_values =
Array::New(params.num_optional_parameters);
Instead of using a growable array, consider allocating the correct size array
right away, since the size is known up-front.

https://codereview.chromium.org/1307943008/diff/20001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1307943008/diff/20001/runtime/vm/parser.cc#ne...
runtime/vm/parser.cc:1339: ZoneGrowableArray<const Instance*>* default_values) {
I think the default_values parameter could be eliminated here and in other
places. Instead of using this out-parameter, the parseXXX functions could
directly set the default values in parsed_function().

https://codereview.chromium.org/1307943008/diff/20001/runtime/vm/parser.h
File runtime/vm/parser.h (right):

https://codereview.chromium.org/1307943008/diff/20001/runtime/vm/parser.h#new...
runtime/vm/parser.h:98: const Instance& DefaultParameterAt(intptr_t i) const {
Should probably be named DefaultParameterValueAt()

[srdjan, 2015-08-25 00:06:31]

https://codereview.chromium.org/1307943008/diff/20001/runtime/vm/parser.cc
File runtime/vm/parser.cc (left):

https://codereview.chromium.org/1307943008/diff/20001/runtime/vm/parser.cc#ol...
runtime/vm/parser.cc:7230: *default_values =
Array::New(params.num_optional_parameters);
On 2015/08/24 23:32:39, hausner wrote:
> Instead of using a growable array, consider allocating the correct size array
> right away, since the size is known up-front.

The change is turning up quite complicated, will do it in a follow up CL.

https://codereview.chromium.org/1307943008/diff/20001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1307943008/diff/20001/runtime/vm/parser.cc#ne...
runtime/vm/parser.cc:1339: ZoneGrowableArray<const Instance*>* default_values) {
On 2015/08/24 23:32:39, hausner wrote:
> I think the default_values parameter could be eliminated here and in other
> places. Instead of using this out-parameter, the parseXXX functions could
> directly set the default values in parsed_function().

ditto.

https://codereview.chromium.org/1307943008/diff/20001/runtime/vm/parser.h
File runtime/vm/parser.h (right):

https://codereview.chromium.org/1307943008/diff/20001/runtime/vm/parser.h#new...
runtime/vm/parser.h:98: const Instance& DefaultParameterAt(intptr_t i) const {
On 2015/08/24 23:32:39, hausner wrote:
> Should probably be named DefaultParameterValueAt()

Done.

[srdjan, 2015-08-25 00:23:26]

Committed patchset #3 (id:40001) manually as
304dc3486f92cf7e81f9bf1e089b6da9b8047981 (presubmit successful).