Issue 1307853004: Improve the heuristics for "pub get" is needed.

Issue 1307853004: Improve the heuristics for "pub get" is needed. (Closed)

Created:
5 years, 3 months ago by nweiz

Modified:
5 years, 3 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/pub.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Improve the heuristics for "pub get" is needed. Instead of relying only on modification times, this does a more complex compatibility check if the modification times of the pubspec, lockfile, and .packages file aren't ordered properly. If they are up-to-date, it updates the modification times accordingly. This also fixes a case where "pub run" wasn't properly checking that the dependencies were up-to-date. Closes #1322 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/1c08b841158e33b8090bb07e5c39df830db58d44

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review changes #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+509 lines, -75 lines)			Patch
M	lib/src/command/deps.dart	View	1	5 chunks	+17 lines, -6 lines	0 comments	Download
M	lib/src/entrypoint.dart	View	1	14 chunks	+134 lines, -26 lines	0 comments	Download
M	lib/src/executable.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	lib/src/io.dart	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	test/must_pub_get_test.dart	View		2 chunks	+318 lines, -35 lines	0 comments	Download
M	test/test_pub.dart	View		1 chunk	+27 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM! https://codereview.chromium.org/1307853004/diff/1/lib/src/command/deps.dart File lib/src/command/deps.dart (right): https://codereview.chromium.org/1307853004/diff/1/lib/src/command/deps.dart#newcode187 lib/src/command/deps.dart:187: /// avaialble. "available" https://codereview.chromium.org/1307853004/diff/1/lib/src/entrypoint.dart File lib/src/entrypoint.dart (right): https://codereview.chromium.org/1307853004/diff/1/lib/src/entrypoint.dart#newcode525 ...

5 years, 3 months ago (2015-08-31 19:32:22 UTC) #2

nweiz

Committed patchset #2 (id:20001) manually as 1c08b841158e33b8090bb07e5c39df830db58d44 (presubmit successful).

5 years, 3 months ago (2015-08-31 20:40:16 UTC) #4

nweiz

5 years, 3 months ago (2015-08-31 20:41:29 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/1307853004/diff/1/lib/src/command/deps.dart
File lib/src/command/deps.dart (right):

https://codereview.chromium.org/1307853004/diff/1/lib/src/command/deps.dart#n...
lib/src/command/deps.dart:187: /// avaialble.
On 2015/08/31 19:32:21, Bob Nystrom wrote:
> "available"

Done.

https://codereview.chromium.org/1307853004/diff/1/lib/src/entrypoint.dart
File lib/src/entrypoint.dart (right):

https://codereview.chromium.org/1307853004/diff/1/lib/src/entrypoint.dart#new...
lib/src/entrypoint.dart:525: // For cached sources, Make sure the directory
exists and looks like a
On 2015/08/31 19:32:21, Bob Nystrom wrote:
> "Make" -> "make"

Done.

Expand Messages | Collapse Messages