Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1307833002: - Prevent interrupting the NULL thread when the isolate is (Closed)

Created:
5 years, 4 months ago by Ivan Posva
Modified:
5 years, 4 months ago
Reviewers:
koda, Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Prevent interrupting the NULL thread when the isolate is exiting from within a thread. BUG= Committed: https://github.com/dart-lang/sdk/commit/3aa62d03fcbffc2f2a77f05d2c8e975b75a56d76

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M runtime/vm/isolate.cc View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Ivan Posva
TBR
5 years, 4 months ago (2015-08-21 05:59:55 UTC) #2
Ivan Posva
Committed patchset #1 (id:1) manually as 3aa62d03fcbffc2f2a77f05d2c8e975b75a56d76 (presubmit successful).
5 years, 4 months ago (2015-08-21 06:00:11 UTC) #3
koda
lgtm
5 years, 4 months ago (2015-08-21 12:06:51 UTC) #4
Cutch
5 years, 4 months ago (2015-08-21 12:41:18 UTC) #5
Message was sent while issue was closed.
On 2015/08/21 12:06:51, koda wrote:
> lgtm

lgtm and thanks!

Powered by Google App Engine
This is Rietveld 408576698