Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 1307653002: Mark invalid package config tests as 'Crash, OK' for analyzer. (Closed)

Created:
5 years, 4 months ago by Harry Terkelsen
Modified:
5 years, 4 months ago
Reviewers:
pquitslund
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Mark invalid package config tests as 'Crash, OK' for analyzer. The analyzer terminates with nonzero exit code if given an invalid package spec. BUG= R=pquitslund@google.com Committed: https://github.com/dart-lang/sdk/commit/ccc8a1c5386db9c585ed89ad48b2a7f37ad01cda

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M tests/standalone/standalone.status View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Harry Terkelsen
I also removed the 'Crash' status for the fixed test.
5 years, 4 months ago (2015-08-20 22:12:54 UTC) #2
pquitslund
LGTM. Thanks!
5 years, 4 months ago (2015-08-20 22:46:05 UTC) #3
Harry Terkelsen
5 years, 4 months ago (2015-08-20 22:48:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ccc8a1c5386db9c585ed89ad48b2a7f37ad01cda (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698