Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1307593003: Reland More allocation tracing unit tests (Closed)

Created:
5 years, 4 months ago by Cutch
Modified:
5 years, 4 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reland More allocation tracing unit tests - Context allocation unit test. - Class allocation unit test. - Adjust behaviour of RecordAllocation when we haven't exited Dart code and we aren't profiling the VM to match the sampler. - Fix tests to ignore embedder samples by default BUG= Committed: https://github.com/dart-lang/sdk/commit/7e2113bc6e91bb948d9a73cd2b0ef0fc9830a1f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -9 lines) Patch
M runtime/vm/profiler.cc View 2 chunks +10 lines, -7 lines 0 comments Download
M runtime/vm/profiler_test.cc View 2 chunks +149 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Cutch
TBR
5 years, 4 months ago (2015-08-20 20:08:15 UTC) #2
Cutch
5 years, 4 months ago (2015-08-20 20:09:01 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
7e2113bc6e91bb948d9a73cd2b0ef0fc9830a1f8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698