Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 130743005: Revert "Use a real package-root for all of our samples (and tests inside a package) instead of buil… (Closed)

Created:
6 years, 11 months ago by kustermann
Modified:
6 years, 11 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Use a real package-root for all of our samples (and tests inside a package) instead of buildDir/packages/" Committed: https://code.google.com/p/dart/source/detail?r=31693

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -236 lines) Patch
M dart/pkg/pkg.status View 1 chunk +0 lines, -28 lines 0 comments Download
M dart/pkg/polymer/example/canonicalization/pubspec.yaml View 1 chunk +2 lines, -1 line 0 comments Download
M dart/tools/testing/dart/test_runner.dart View 5 chunks +2 lines, -68 lines 0 comments Download
M dart/tools/testing/dart/test_suite.dart View 10 chunks +12 lines, -139 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kustermann
6 years, 11 months ago (2014-01-10 12:58:37 UTC) #1
kustermann
Committed patchset #1 manually as r31693 (presubmit successful).
6 years, 11 months ago (2014-01-10 12:58:41 UTC) #2
Bill Hesse
6 years, 11 months ago (2014-01-10 15:54:39 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698